Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: chrome/browser/media/router/presentation_service_delegate_impl.h

Issue 1259073004: [Presentation API] Change ListenForSessionMessages API to client-style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/presentation_service_delegate_impl.h
diff --git a/chrome/browser/media/router/presentation_service_delegate_impl.h b/chrome/browser/media/router/presentation_service_delegate_impl.h
index 2085fce29159ff028eedcf78a17bfff131cfa022..c26adbf43e3eb5fad4de41891fbe4502846a3ec0 100644
--- a/chrome/browser/media/router/presentation_service_delegate_impl.h
+++ b/chrome/browser/media/router/presentation_service_delegate_impl.h
@@ -91,12 +91,13 @@ class PresentationServiceDelegateImpl
void ListenForSessionMessages(
int render_process_id,
int render_frame_id,
- const PresentationSessionMessageCallback& message_cb) override;
- void SendMessage(
- int render_process_id,
- int render_frame_id,
- scoped_ptr<content::PresentationSessionMessage> message_request,
- const SendMessageCallback& send_message_cb) override;
+ const content::PresentationSessionInfo& session,
+ const content::PresentationSessionMessageCallback& message_cb) override;
+ void SendMessage(int render_process_id,
+ int render_frame_id,
+ const content::PresentationSessionInfo& session,
+ scoped_ptr<content::PresentationSessionMessage> message,
+ const SendMessageCallback& send_message_cb) override;
void ListenForSessionStateChange(
int render_process_id,
int render_frame_id,
@@ -106,7 +107,9 @@ class PresentationServiceDelegateImpl
// outside of a Presentation API request. This could be due to
// browser action (e.g., browser initiated media router dialog) or
// a media route provider (e.g., autojoin).
- void OnRouteResponse(const MediaRoute* route, const std::string& error);
+ void OnRouteResponse(const MediaRoute* route,
+ const std::string& presentation_id,
+ const std::string& error);
// Returns the default MediaSource for this tab if there is one.
// Returns an empty MediaSource otherwise.
@@ -160,6 +163,7 @@ class PresentationServiceDelegateImpl
const PresentationSessionSuccessCallback& success_cb,
const PresentationSessionErrorCallback& error_cb,
const MediaRoute* route,
+ const std::string& presentation_id,
const std::string& error_text);
void OnStartSessionSucceeded(
« no previous file with comments | « chrome/browser/media/router/mock_media_router.h ('k') | chrome/browser/media/router/presentation_service_delegate_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698