Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 1259063004: X87: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. port 5dff4bdff06c0463db1e876af7541af2b715392c (r29886). original commit message: No need to pass the name explicitly to the stubs; the runtime can extract the name from the ScopeInfo (the extension of the ScriptContext) on-demand easily without any performance impact. BUG= Committed: https://crrev.com/029ca8ca6b6efaf16ae10352e5fafdc9591f0e4e Cr-Commit-Position: refs/heads/master@{#29892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 5 chunks +5 lines, -11 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-07-28 07:49:24 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-07-28 08:10:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259063004/1
5 years, 4 months ago (2015-07-28 08:10:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 08:37:27 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 08:37:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/029ca8ca6b6efaf16ae10352e5fafdc9591f0e4e
Cr-Commit-Position: refs/heads/master@{#29892}

Powered by Google App Engine
This is Rietveld 408576698