Service Worker: Use ScriptPromise instead of ScriptPromise&.

Service Worker: Use ScriptPromise instead of ScriptPromise&.

Replace |ScriptPromise&| with |ScriptPromise| for FetchEvent::respondWith() and
RespondWithObserver::respondWith(). This CL addresses a comment given by
yhirano@: https://codereview.chromium.org/1256133002/#msg8.

BUG=N/A

Committed: https://crrev.com/dc6e57649056db3ca6ac8d06422c4af371f2d3bc
git-svn-id: svn://svn.chromium.org/blink/trunk@199654 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[jungkees, 2015-07-27 15:23:36]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, jinho.bang@samsung.com, kinuko@chromium.org,
l.gombos@samsung.com, michaeln@chromium.org, nhiroki@chromium.org,
yhirano@chromium.org

[jungkees, 2015-07-27 15:24:37]

I addressed yhirano@'s comment from
https://codereview.chromium.org/1256133002/#msg8. PTAL.

[yhirano, 2015-07-29 06:30:26]

lgtm

https://codereview.chromium.org/1259023002/diff/1/Source/modules/serviceworke...
File Source/modules/serviceworkers/FetchEvent.h (right):

https://codereview.chromium.org/1259023002/diff/1/Source/modules/serviceworke...
Source/modules/serviceworkers/FetchEvent.h:7: 
+ScriptPromise.h

https://codereview.chromium.org/1259023002/diff/1/Source/modules/serviceworke...
Source/modules/serviceworkers/FetchEvent.h:20: class RespondWithObserver;
+ScriptState

[jungkees, 2015-07-29 08:27:57]

Addressed the comments. Thanks for review yhirano@!

SW OWNERs, PTAL.

[nhiroki, 2015-07-29 08:52:19]

LGTM with a nit

https://codereview.chromium.org/1259023002/diff/20001/Source/modules/servicew...
File Source/modules/serviceworkers/FetchEvent.h (right):

https://codereview.chromium.org/1259023002/diff/20001/Source/modules/servicew...
Source/modules/serviceworkers/FetchEvent.h:22: class ScriptPromise;
nit: ScriptState? (This file already included ScriptPromise.h)

[jungkees, 2015-07-29 09:12:23]

Addressed the comment. Thanks for review!

https://codereview.chromium.org/1259023002/diff/20001/Source/modules/servicew...
File Source/modules/serviceworkers/FetchEvent.h (right):

https://codereview.chromium.org/1259023002/diff/20001/Source/modules/servicew...
Source/modules/serviceworkers/FetchEvent.h:22: class ScriptPromise;
Yeah, right. I finally removed the forward declaration for this case.

I just wonder what'd be the best practice for it. IMHO, this header file doesn't
need the *definition* of the ScriptPromise, so it seems a forward declaration is
enough here. But in that case, I'll need to include ScriptPromise.h file in
FetchEvent.cpp anyway where the definition is needed, right?

[jungkees, 2015-07-29 09:12:30]

The CQ bit was checked by jungkee.song@samsung.com

[jungkees, 2015-07-29 09:12:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
yhirano@chromium.org, nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1259023002/#ps40001
(title: "Remove the forward declaration (Included header will do).")

[commit-bot: I haz the power, 2015-07-29 09:13:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1259023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1259023002/40001

[commit-bot: I haz the power, 2015-07-29 10:12:04]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199654

[commit-bot: I haz the power, 2015-09-23 11:53:21]

Patchset 3 (id:??) landed as
https://crrev.com/dc6e57649056db3ca6ac8d06422c4af371f2d3bc