Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1259013002: Add per-file OWNERS for PPC-specific cctests (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add per-file OWNERS for PPC-specific cctests BUG= R=jkummerow@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/aabb08d8cc89104165911de7301225c5f0513ee9 Cr-Commit-Position: refs/heads/master@{#29901}

Patch Set 1 #

Patch Set 2 : temporarily remove Junliang #

Patch Set 3 : add back Junliang #

Patch Set 4 : Alphabetize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/OWNERS View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-27 14:58:58 UTC) #2
michael_dawson
On 2015/07/27 14:58:58, mtbrandyberry wrote: lgtm.
5 years, 4 months ago (2015-07-27 15:13:22 UTC) #3
MTBrandyberry
On 2015/07/27 15:13:22, michael_dawson wrote: > On 2015/07/27 14:58:58, mtbrandyberry wrote: > > lgtm. Bump. ...
5 years, 4 months ago (2015-07-28 12:54:19 UTC) #5
Jakob Kummerow
LGTM. Please sort the list alphabetically.
5 years, 4 months ago (2015-07-28 13:22:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259013002/60001
5 years, 4 months ago (2015-07-28 16:11:51 UTC) #9
MTBrandyberry
On 2015/07/28 13:22:01, Jakob wrote: > LGTM. Please sort the list alphabetically. Thank you!
5 years, 4 months ago (2015-07-28 16:40:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1259013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1259013002/60001
5 years, 4 months ago (2015-07-29 08:10:29 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-29 08:12:03 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 08:12:14 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/aabb08d8cc89104165911de7301225c5f0513ee9
Cr-Commit-Position: refs/heads/master@{#29901}

Powered by Google App Engine
This is Rietveld 408576698