Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1258963005: remove now-dead flags (Closed)

Created:
5 years, 4 months ago by reed1
Modified:
5 years, 4 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkImageInfo.h View 2 chunks +1 line, -7 lines 0 comments Download
M include/core/SkScalar.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
reed1
should be landable after related android-master CL lands (739741)
5 years, 4 months ago (2015-07-31 22:02:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258963005/1
5 years, 4 months ago (2015-07-31 22:02:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 22:10:08 UTC) #6
scroggo
On 2015/07/31 22:02:45, reed1 wrote: > should be landable after related android-master CL lands (739741) ...
5 years, 4 months ago (2015-07-31 22:12:23 UTC) #7
scroggo
LGTM
5 years, 4 months ago (2015-07-31 22:12:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258963005/1
5 years, 4 months ago (2015-08-01 14:02:55 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-01 14:03:23 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c2e682795218268845d097dd41a92e72084c43f0

Powered by Google App Engine
This is Rietveld 408576698