Make the Response constructor throw when status is a null body status and body is non-null

Source/modules/fetch/Response.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/fetch/Response.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/DOMArrayBuffer.h"
@@ skipping 135 matching lines @@
         const long long length = blobData->length();
         Blob* blob = Blob::create(BlobDataHandle::create(blobData.release(), length));
         return create(context, blob, ResponseInit(responseInit, exceptionState), exceptionState);
     }
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 Response* Response::create(ExecutionContext* context, Blob* body, const ResponseInit& responseInit, ExceptionState& exceptionState)
 {
-    // "1. If |init|'s status member is not in the range 200 to 599, throw a
-    // RangeError."
-    if (responseInit.status < 200 || 599 < responseInit.status) {
+    unsigned short status = responseInit.status;
+
+    // "1. If init's status member is either not in the range 200 to 599, inclusive,
+    // or is a null body status, throw a RangeError. A null body status is 101, 204, 205, or 304,
+    // spec link, See https://fetch.spec.whatwg.org/#null-body-status for details"

[hiroshige, 2015/07/29 11:49:11]

According to the latest spec,
- null body status check is in Step 7.1, not Step 1. here.
- TypeError (not RangeError) must be thrown.

https://fetch.spec.whatwg.org/#dom-response
https://github.com/whatwg/fetch/commit/1e0918db0593d3068e4f042225371069b147ed0c

[shiva.jm, 2015/07/30 09:10:42]

Done.

+    if (status < 200 || status == 204 || status == 205 || status == 304 || 599 < status) {

[hiroshige, 2015/07/29 11:49:11]

Please define isNullBodyStatus() in the anonymous name space above and use it.

[shiva.jm, 2015/07/30 09:10:42]

Done.

         exceptionState.throwRangeError("Invalid status");
         return 0;
     }
 
     // "2. If |init|'s statusText member does not match the Reason-Phrase
     // token production, throw a TypeError."
     if (!isValidReasonPhrase(responseInit.statusText)) {
         exceptionState.throwTypeError("Invalid statusText");
         return 0;
     }
@@ skipping 265 matching lines @@
 }
 
 DEFINE_TRACE(Response)
 {
     Body::trace(visitor);
     visitor->trace(m_response);
     visitor->trace(m_headers);
 }
 
 } // namespace blink