Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1258923010: Add CancelableIdleTask. (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add CancelableIdleTask. BUG=chromium:490559 LOG=NO Committed: https://crrev.com/0dc4c959336cfd02bcb203974bc44e4633492e58 Cr-Commit-Position: refs/heads/master@{#29935}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M src/cancelable-task.h View 1 2 chunks +40 lines, -9 lines 0 comments Download
M src/cancelable-task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
ptal
5 years, 4 months ago (2015-07-30 11:48:14 UTC) #2
epertoso
lgtm https://codereview.chromium.org/1258923010/diff/1/src/cancelable-task.h File src/cancelable-task.h (right): https://codereview.chromium.org/1258923010/diff/1/src/cancelable-task.h#newcode57 src/cancelable-task.h:57: // Task overrides. These are IdleTask overrides.
5 years, 4 months ago (2015-07-30 12:05:30 UTC) #3
ulan
Thanks, landing. https://codereview.chromium.org/1258923010/diff/1/src/cancelable-task.h File src/cancelable-task.h (right): https://codereview.chromium.org/1258923010/diff/1/src/cancelable-task.h#newcode57 src/cancelable-task.h:57: // Task overrides. On 2015/07/30 12:05:30, epertoso ...
5 years, 4 months ago (2015-07-30 13:22:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258923010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258923010/20001
5 years, 4 months ago (2015-07-30 13:22:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 14:09:05 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 14:09:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0dc4c959336cfd02bcb203974bc44e4633492e58
Cr-Commit-Position: refs/heads/master@{#29935}

Powered by Google App Engine
This is Rietveld 408576698