Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1258893004: Revert of Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium] (Closed)

Created:
5 years, 4 months ago by johnme
Modified:
5 years, 4 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium] (patchset #1 id:40001 of https://codereview.chromium.org/1242953007/) Reason for revert: This broke http/tests/serviceworker/fetch-request-fallback.html, causing failures on 3 bots and timeouts on 18 bots. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fserviceworker%2Ffetch-request-fallback.html&testType=layout-tests Original issue's description: > Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium] > > We are sending CORS fallback response from the browser process to the page's renderer process, when the ServiceWorker doesn't handle the CORS fetch request. > But when the request URL's origin is same as the page's security origin, we can skip the fallback and send the request from the browser process. > > This change will improve the delay of the CORS fallback for same origin requests, especially when the renderer main thread is busy. > > 1/2 blink: https://codereview.chromium.org/1243353002/ > 2/2 chromium: this cl. > > BUG=512764 > > Committed: https://crrev.com/97b13409b0c601f21f048744fa8e31852b476337 > Cr-Commit-Position: refs/heads/master@{#341482} TBR=falken@chromium.org,tyoshino@chromium.org,horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512764 Committed: https://crrev.com/ac2794675706a635dd3e54245c27f64411927a6c Cr-Commit-Position: refs/heads/master@{#341499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M content/browser/service_worker/service_worker_url_request_job.cc View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
johnme
Created Revert of Skip the Service Worker CORS fallback for same origin requests. [2/2 chromium]
5 years, 4 months ago (2015-08-03 08:47:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258893004/1
5 years, 4 months ago (2015-08-03 08:47:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 08:48:27 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac2794675706a635dd3e54245c27f64411927a6c Cr-Commit-Position: refs/heads/master@{#341499}
5 years, 4 months ago (2015-08-03 08:49:04 UTC) #4
horo
5 years, 4 months ago (2015-08-10 07:39:49 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1282193002/ by horo@chromium.org.

The reason for reverting is: LayoutTest failure was fixed by
https://codereview.chromium.org/1274973002/.

Powered by Google App Engine
This is Rietveld 408576698