Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1258873002: X87: implement MathPow stub for X87. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: implement MathPow stub for X87. In CL 0fe2fbd173c5e547e021476428001cac6fcdf7a9 the implementation of MathPow for all ports are unified and MathPow stub code is invoked. So we move the direct runtime function call from full-codegen to MathPow stub for X87 platform. BUG= Committed: https://crrev.com/5c5c55fb94d5be4195d1fda72ca535dd014c967e Cr-Commit-Position: refs/heads/master@{#29865}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +22 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-07-27 08:55:37 UTC) #3
Weiliang
lgtm
5 years, 5 months ago (2015-07-27 09:40:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258873002/20001
5 years, 5 months ago (2015-07-27 09:40:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-27 10:05:33 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-27 10:05:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c5c55fb94d5be4195d1fda72ca535dd014c967e
Cr-Commit-Position: refs/heads/master@{#29865}

Powered by Google App Engine
This is Rietveld 408576698