sync/syncable/directory.cc - Issue 1258863007: [Sync] Add more info for invalid position check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/directory.cc

Issue 1258863007: [Sync] Add more info for invalid position check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove change from directory since too much test failures Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/directory.cc

diff --git a/sync/syncable/directory.cc b/sync/syncable/directory.cc

index 720a924e4a6b801a802e55ad825834e7e2509542..1a5faf1f876c4852c53a9ea46a5cd4aef1dd0101 100644

--- a/sync/syncable/directory.cc

+++ b/sync/syncable/directory.cc

@@ -1469,7 +1469,7 @@ void Directory::PutPredecessor(EntryKernel* e, EntryKernel* predecessor) {

// without valid positions. See TODO above.

// Using a release CHECK here because the following UniquePosition::Between

// call crashes anyway when the position string is empty (see crbug/332371).

- CHECK(successor->ref(UNIQUE_POSITION).IsValid());

+ CHECK(successor->ref(UNIQUE_POSITION).IsValid()) << *successor;

// Finally, the normal case: inserting between two elements.

UniquePosition pos = UniquePosition::Between(

« no previous file with comments | « no previous file | sync/syncable/entry.cc » ('j') | sync/syncable/entry_kernel.h » ('J')