Source/bindings/scripts/v8_utilities.py - Issue 1258863003: bindings: Moves [OverrideBuiltins]'s attributes to the prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 1258863003: bindings: Moves [OverrideBuiltins]'s attributes to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated the test results. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_utilities.py

diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py

index e1e584be75bec46fea220ae4828f19f69518b38c..149352085eb788a6162cc241b553ed45e5c7c454 100644

--- a/Source/bindings/scripts/v8_utilities.py

+++ b/Source/bindings/scripts/v8_utilities.py

@@ -461,8 +461,7 @@ def on_prototype(interface, member):

# These members must not be placed on prototype chains.

if (is_constructor_attribute(member) or

member.is_static or

- is_unforgeable(interface, member) or

- 'OverrideBuiltins' in interface.extended_attributes):

+ is_unforgeable(interface, member)):

return False

# TODO(yukishiino): We should handle [Global] and [PrimaryGlobal] instead of

« no previous file with comments | « LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | no next file » | no next file with comments »