Issue 1258833005: Removing GetWebViewFactory method in WebClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1258833005: Removing GetWebViewFactory method in WebClient. (Closed)

Created:
5 years, 4 months ago by shreyasv1

Modified:
5 years, 4 months ago

Reviewers:
Eugene But (OOO till 7-30)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Removing GetWebViewFactory method in WebClient. Looks like this is cruft from when the class was actually removed. Committed: https://crrev.com/eb2801e9cd3e6406282bc1b3f825f0957e76bd87 Cr-Commit-Position: refs/heads/master@{#341633}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -10 lines)			Patch
M	ios/web/public/test/test_web_client.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ios/web/public/web_client.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	ios/web/public/web_client.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258833005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258833005/1

5 years, 4 months ago (2015-08-03 22:30:34 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-03 22:47:37 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eb2801e9cd3e6406282bc1b3f825f0957e76bd87
Cr-Commit-Position: refs/heads/master@{#341633}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages