Remove redundant icon from controlled setting popup bubble.

Remove redundant icon from controlled setting popup bubble.

See screenshot on bug.

BUG=315378
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244478

[Dan Beam, 2014-01-07 17:28:53]

https://codereview.chromium.org/125883002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/controlled_setting.css (right):

https://codereview.chromium.org/125883002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/controlled_setting.css:58: background-size:
22px;
can you combine this?

  .controlled-setting-bubble-content[controlled-by='extension'] {
    background: no-repeat url(chrome://theme/IDR_CONTROLLED_SETTING_EXTENSION);
    background-size: 22px;
  }

https://codereview.chromium.org/125883002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/controlled_setting.css:62: background-image:
url('chrome://theme/IDR_CONTROLLED_SETTING_EXTENSION');
^ why does this version of the bubble still get an icon in it?

[dconnelly, 2014-01-08 09:18:23]

https://codereview.chromium.org/125883002/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/controlled_setting.css (right):

https://codereview.chromium.org/125883002/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/controlled_setting.css:62: background-image:
url('chrome://theme/IDR_CONTROLLED_SETTING_EXTENSION');
On 2014/01/07 17:28:53, Dan Beam wrote:
> ^ why does this version of the bubble still get an icon in it?

It shouldn't. Brain failure. Thanks. That obviates the previous comment. I also
added another screenshot to the bug.

[Dan Beam, 2014-01-08 21:55:34]

can you remove these lines as well?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

https://codereview.chromium.org/125883002/diff/90001/chrome/browser/resources...
File chrome/browser/resources/options/controlled_setting.css (left):

https://codereview.chromium.org/125883002/diff/90001/chrome/browser/resources...
chrome/browser/resources/options/controlled_setting.css:72: background-image:
url('chrome://theme/IDR_CONTROLLED_SETTING_EXTENSION');
^ where else is this used now?

[dconnelly, 2014-01-09 08:25:31]

"can you remove these lines as well?"

Which lines?

https://codereview.chromium.org/125883002/diff/90001/chrome/browser/resources...
File chrome/browser/resources/options/controlled_setting.css (left):

https://codereview.chromium.org/125883002/diff/90001/chrome/browser/resources...
chrome/browser/resources/options/controlled_setting.css:72: background-image:
url('chrome://theme/IDR_CONTROLLED_SETTING_EXTENSION');
On 2014/01/08 21:55:35, Dan Beam wrote:
> ^ where else is this used now?

Do you mean the resource? It's still used to mark the settings on the page, we
just aren't using it in the bubble.

[Dan Beam, 2014-01-09 17:13:35]

On 2014/01/08 21:55:34, Dan Beam wrote:
> can you remove these lines as well?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

^ the lines that i linked to

[dconnelly, 2014-01-10 09:21:58]

On 2014/01/09 17:13:35, Dan Beam wrote:
> On 2014/01/08 21:55:34, Dan Beam wrote:
> > can you remove these lines as well?
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> 
> ^ the lines that i linked to

Sorry, I scanned past that as Rietveld boilerplate. Yes, done.

[Dan Beam, 2014-01-10 21:51:50]

On 2014/01/10 09:21:58, dconnelly wrote:
> On 2014/01/09 17:13:35, Dan Beam wrote:
> > On 2014/01/08 21:55:34, Dan Beam wrote:
> > > can you remove these lines as well?
> > > 
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> > 
> > ^ the lines that i linked to
> 
> Sorry, I scanned past that as Rietveld boilerplate. Yes, done.

it's all good, that's what i figured.

lgtm

[commit-bot: I haz the power, 2014-01-13 08:03:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/125883002/160001

[commit-bot: I haz the power, 2014-01-13 09:44:38]

Change committed as 244478