Add switch to run ash tests on desktop in windows 8.

Add switch to run ash tests on desktop in windows 8.

BUG=NONE
TEST=NONE
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190468

[scottmg, 2013-03-14 21:43:15]

lgtm

https://codereview.chromium.org/12588008/diff/1/ash/ash_switches.cc
File ash/ash_switches.cc (right):

https://codereview.chromium.org/12588008/diff/1/ash/ash_switches.cc#newcode125
ash/ash_switches.cc:125: const char kForceAshToDesktop[] = "force-desktop";
maybe ash-force-desktop like most of the other switches here

[robertshield, 2013-03-14 22:02:50]

https://codereview.chromium.org/12588008/diff/1/ash/ash_switches.cc
File ash/ash_switches.cc (right):

https://codereview.chromium.org/12588008/diff/1/ash/ash_switches.cc#newcode125
ash/ash_switches.cc:125: const char kForceAshToDesktop[] = "force-desktop";
On 2013/03/14 21:43:15, scottmg wrote:
> maybe ash-force-desktop like most of the other switches here

Done.

[commit-bot: I haz the power, 2013-03-14 22:06:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12588008/4001

[commit-bot: I haz the power, 2013-03-14 22:07:05]

Presubmit check for 12588008-4001 failed and returned exit status 1.

INFO:root:Found 5 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ash/ash_switches.h
    ash/host/root_window_host_factory_win.cc
    ash/ash_switches.cc
    ash/test/ash_test_base.cc
    ash/test/test_suite.cc

[robertshield, 2013-03-15 01:21:54]

+Ben for OWNERS

[robertshield, 2013-03-15 01:22:32]

+Ben

[robertshield, 2013-03-18 20:16:05]

On 2013/03/15 01:22:32, robertshield wrote:
> +Ben

@Ben: Ping

[commit-bot: I haz the power, 2013-03-19 19:31:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12588008/4001

[commit-bot: I haz the power, 2013-03-19 22:26:32]

Retried try job too often on win_rel for step(s) browser_tests,
chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests,
content_browsertests, installer_util_unittests, mini_installer_test,
nacl_integration, sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Ben Goodger (Google), 2013-03-19 22:56:31]

lgtm

[commit-bot: I haz the power, 2013-03-22 02:10:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12588008/4001

[commit-bot: I haz the power, 2013-03-22 02:10:43]

Failed to apply patch for ash/ash_switches.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/ash_switches.h
  Hunk #1 FAILED at 46.
  1 out of 1 hunk FAILED -- saving rejects to file ash/ash_switches.h.rej

Patch:       ash/ash_switches.h
Index: ash/ash_switches.h
diff --git a/ash/ash_switches.h b/ash/ash_switches.h
index
ee61b030d315a88d9244c40b80621e9297f6e9bc..c4b21abef54d4811949ac93b8d65163823ebddfe
100644
--- a/ash/ash_switches.h
+++ b/ash/ash_switches.h
@@ -46,6 +46,9 @@ ASH_EXPORT extern const char kAshSecondaryDisplayLayout[];
 ASH_EXPORT extern const char kAshTouchHud[];
 ASH_EXPORT extern const char kAuraLegacyPowerButton[];
 ASH_EXPORT extern const char kAshOverrideDisplayOrientation[];
+#if defined(OS_WIN)
+ASH_EXPORT extern const char kForceAshToDesktop[];
+#endif
 
 }  // namespace switches
 }  // namespace ash

[commit-bot: I haz the power, 2013-03-22 22:11:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12588008/30001

[commit-bot: I haz the power, 2013-03-22 22:11:14]

Failed to apply patch for ash/ash_switches.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/ash_switches.h
  Hunk #1 FAILED at 46.
  1 out of 1 hunk FAILED -- saving rejects to file ash/ash_switches.h.rej

Patch:       ash/ash_switches.h
Index: ash/ash_switches.h
diff --git a/ash/ash_switches.h b/ash/ash_switches.h
index
ee61b030d315a88d9244c40b80621e9297f6e9bc..c4b21abef54d4811949ac93b8d65163823ebddfe
100644
--- a/ash/ash_switches.h
+++ b/ash/ash_switches.h
@@ -46,6 +46,9 @@ ASH_EXPORT extern const char kAshSecondaryDisplayLayout[];
 ASH_EXPORT extern const char kAshTouchHud[];
 ASH_EXPORT extern const char kAuraLegacyPowerButton[];
 ASH_EXPORT extern const char kAshOverrideDisplayOrientation[];
+#if defined(OS_WIN)
+ASH_EXPORT extern const char kForceAshToDesktop[];
+#endif
 
 }  // namespace switches
 }  // namespace ash

[commit-bot: I haz the power, 2013-03-25 16:59:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robertshield@chromium.org/12588008/35001

[commit-bot: I haz the power, 2013-03-25 20:23:42]

Change committed as 190468