Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1258743004: MIPS: Fix disassembler for J and JAL instructions. (Closed)

Created:
5 years, 4 months ago by Ilija.Pavlovic1
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix disassembler for J and JAL instructions. Adapted disassembler for J and JAL instructions. TEST=cctest/test-disasm-mips/Type0, cctest/test-disasm-mips64/Type3 BUG= Committed: https://crrev.com/496bd53bcc9d5d58c5df2e707933b47f2dd2fecd Cr-Commit-Position: refs/heads/master@{#29921}

Patch Set 1 #

Patch Set 2 : Fix disassembler for J and JAL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/mips/disasm-mips.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Ilija.Pavlovic1
5 years, 4 months ago (2015-07-28 11:08:54 UTC) #2
petarj
On 2015/07/28 11:08:54, Ilija.Pavlovic1 wrote: This should be fixed in disassembler rather than changing the ...
5 years, 4 months ago (2015-07-28 11:44:52 UTC) #3
paul.l...
patchset 2 lgtm. But a couple nits in commit message: title should remove the word ...
5 years, 4 months ago (2015-07-28 14:26:27 UTC) #4
Ilija.Pavlovic1
On 2015/07/28 14:26:27, paul.l... wrote: > patchset 2 lgtm. > > But a couple nits ...
5 years, 4 months ago (2015-07-28 15:37:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258743004/20001
5 years, 4 months ago (2015-07-28 15:39:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258743004/20001
5 years, 4 months ago (2015-07-29 11:50:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 09:16:39 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 09:16:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/496bd53bcc9d5d58c5df2e707933b47f2dd2fecd
Cr-Commit-Position: refs/heads/master@{#29921}

Powered by Google App Engine
This is Rietveld 408576698