Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1258703005: Add more passing tests to CFI buildbot. (Closed)

Created:
5 years, 4 months ago by krasin
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more passing tests to CFI buildbot. BUG=chromium:457523 Committed: https://crrev.com/f522e11114ac4ec76f556436e1cca4cb59fff959 Cr-Commit-Position: refs/heads/master@{#341215}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove swarming option from two tests #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 4 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
krasin
5 years, 4 months ago (2015-07-30 00:44:02 UTC) #2
Nico
https://codereview.chromium.org/1258703005/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1258703005/diff/1/testing/buildbot/chromium.fyi.json#newcode205 testing/buildbot/chromium.fyi.json:205: "can_use_on_swarming_builders": true no other bot runs this test on ...
5 years, 4 months ago (2015-07-30 00:58:42 UTC) #3
krasin
https://codereview.chromium.org/1258703005/diff/1/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/1258703005/diff/1/testing/buildbot/chromium.fyi.json#newcode205 testing/buildbot/chromium.fyi.json:205: "can_use_on_swarming_builders": true On 2015/07/30 00:58:42, Nico wrote: > no ...
5 years, 4 months ago (2015-07-30 01:04:58 UTC) #4
krasin
On 2015/07/30 01:04:58, krasin wrote: > https://codereview.chromium.org/1258703005/diff/1/testing/buildbot/chromium.fyi.json > File testing/buildbot/chromium.fyi.json (right): > > https://codereview.chromium.org/1258703005/diff/1/testing/buildbot/chromium.fyi.json#newcode205 > ...
5 years, 4 months ago (2015-07-30 02:08:07 UTC) #5
krasin
Non update: I have verified that the tests have not yet regressed (as of Chromium ...
5 years, 4 months ago (2015-07-30 21:29:23 UTC) #6
Nico
lgtm
5 years, 4 months ago (2015-07-30 21:34:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258703005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258703005/40001
5 years, 4 months ago (2015-07-30 21:37:30 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 22:50:09 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 22:51:10 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f522e11114ac4ec76f556436e1cca4cb59fff959
Cr-Commit-Position: refs/heads/master@{#341215}

Powered by Google App Engine
This is Rietveld 408576698