Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1258663002: update analyzer and dart_style (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 4 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M lib/src/multi_package_resolver.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M lib/src/server/server.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M test/testing.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
I'm going to need 0.26+ analyzer soon so figure we might as well upgrade. for ...
5 years, 5 months ago (2015-07-24 19:20:17 UTC) #2
vsm
lgtm
5 years, 4 months ago (2015-07-27 16:34:27 UTC) #3
Jennifer Messerly
5 years, 4 months ago (2015-07-27 16:36:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23de692cc5c41b6ae77f5aeffc71f9db1fe8e45a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698