Fix focus loss on chrome signin page

Fix focus loss on chrome signin page

BUG=331733
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243651

[guohui, 2014-01-07 20:26:29]

Hey,

could you please review the CL?

Thanks,

Hui

[xiyuan, 2014-01-07 21:49:47]

https://codereview.chromium.org/125863003/diff/1/chrome/browser/resources/gai...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/125863003/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth/main.js:237: gaiaFrame.focus();
Would this has side effect? e.g. what happens user click on omnibox or click
another browser window?

[guohui, 2014-01-07 22:15:01]

https://codereview.chromium.org/125863003/diff/1/chrome/browser/resources/gai...
File chrome/browser/resources/gaia_auth/main.js (right):

https://codereview.chromium.org/125863003/diff/1/chrome/browser/resources/gai...
chrome/browser/resources/gaia_auth/main.js:237: gaiaFrame.focus();
On 2014/01/07 21:49:48, xiyuan wrote:
> Would this has side effect? e.g. what happens user click on omnibox or click
> another browser window?

the only side effect i have observed is that upon switching back from another
window, the focused element may flicker once as it is refocused. I think it
should be ok as a temporary workaround until webview team fixes the root cause
on their side, TODO added.

[xiyuan, 2014-01-07 22:41:00]

LGTM

Thanks for the clarification.

[commit-bot: I haz the power, 2014-01-07 22:46:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/125863003/60001

[commit-bot: I haz the power, 2014-01-08 01:51:44]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 20:01:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/guohui@chromium.org/125863003/60001

[commit-bot: I haz the power, 2014-01-08 21:37:33]

Change committed as 243651