content/renderer/accessibility/renderer_accessibility_browsertest.cc - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/public/test/test_utils.cc ('k') | content/renderer/devtools/v8_sampling_profiler_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/renderer_accessibility_browsertest.cc

diff --git a/content/renderer/accessibility/renderer_accessibility_browsertest.cc b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

index 0053bcc281ac9ee9f43843c793490d3d5ed70531..1c5c7bdd510ed4ab4181031977bf3da1609c455e 100644

--- a/content/renderer/accessibility/renderer_accessibility_browsertest.cc

+++ b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

@@ -248,10 +248,10 @@ TEST_F(RendererAccessibilityTest, HideAccessibilityObject) {

WebAXObject node_c = node_b.childAt(0);

// Hide node 'B' ('C' stays visible).

- ExecuteJavaScript(

+ ExecuteJavaScriptForTests(

"document.getElementById('B').style.visibility = 'hidden';");

// Force layout now.

- ExecuteJavaScript("document.getElementById('B').offsetLeft;");

+ ExecuteJavaScriptForTests("document.getElementById('B').offsetLeft;");

// Send a childrenChanged on 'A'.

sink_->ClearMessages();

@@ -294,9 +294,9 @@ TEST_F(RendererAccessibilityTest, ShowAccessibilityObject) {

EXPECT_EQ(3, CountAccessibilityNodesSentToBrowser());

// Show node 'B', then send a childrenChanged on 'A'.

- ExecuteJavaScript(

+ ExecuteJavaScriptForTests(

"document.getElementById('B').style.visibility = 'visible';");

- ExecuteJavaScript("document.getElementById('B').offsetLeft;");

+ ExecuteJavaScriptForTests("document.getElementById('B').offsetLeft;");

sink_->ClearMessages();

WebDocument document = view()->GetWebView()->mainFrame()->document();

@@ -355,10 +355,10 @@ TEST_F(RendererAccessibilityTest, DetachAccessibilityObject) {

// Change the display of the second 'span' back to inline, which causes the

// anonymous block to be destroyed.

- ExecuteJavaScript(

+ ExecuteJavaScriptForTests(

"document.querySelectorAll('span')[1].style.display = 'inline';");

// Force layout now.

- ExecuteJavaScript("document.body.offsetLeft;");

+ ExecuteJavaScriptForTests("document.body.offsetLeft;");

// Send a childrenChanged on the body.

sink_->ClearMessages();