components/printing/test/print_web_view_helper_browsertest.cc - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/test/print_web_view_helper_browsertest.cc

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc ('k') | content/browser/accessibility/accessibility_win_browsertest.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/printing/test/print_web_view_helper_browsertest.cc

diff --git a/components/printing/test/print_web_view_helper_browsertest.cc b/components/printing/test/print_web_view_helper_browsertest.cc

index 28d25231ff507568f9cf9a11ec2bc8bf258abbd5..c1eb5847f6450a4c3953a85a12fc2e9b8dc768ef 100644

--- a/components/printing/test/print_web_view_helper_browsertest.cc

+++ b/components/printing/test/print_web_view_helper_browsertest.cc

@@ -153,7 +153,7 @@ class PrintWebViewHelperTestBase : public content::RenderViewTest {

}

void PrintWithJavaScript() {

- ExecuteJavaScript("window.print();");

+ ExecuteJavaScriptForTests("window.print();");

ProcessPendingMessages();

}

// The renderer should be done calculating the number of rendered pages