chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc ('k') | chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

index 8dd18352d69bbbd59fbf14b612a549c1440b753e..42dbcfa196eaec6061ab7dc1ab5b599725571d26 100644

--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

@@ -765,20 +765,20 @@ void GaiaScreenHandler::SubmitLoginFormForTest() {

code += "document.getElementById('Passwd').value = '" + test_pass_ + "';";

code += "document.getElementById('signIn').click();";

- frame->ExecuteJavaScript(base::ASCIIToUTF16(code));

+ frame->ExecuteJavaScriptForTests(base::ASCIIToUTF16(code));

} else {

std::string code;

code =

"document.getElementById('identifier').value = '" + test_user_ + "';";

code += "document.getElementById('nextButton').click();";

- frame->ExecuteJavaScript(base::ASCIIToUTF16(code));

+ frame->ExecuteJavaScriptForTests(base::ASCIIToUTF16(code));

if (!test_pass_.empty()) {

code =

"document.getElementById('password').value = '" + test_pass_ + "';";

code += "document.getElementById('nextButton').click();";

- frame->ExecuteJavaScript(base::ASCIIToUTF16(code));

+ frame->ExecuteJavaScriptForTests(base::ASCIIToUTF16(code));

}