chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java ('k') | chrome/browser/apps/custom_launcher_page_browsertest_views.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

index 091a7b5c72851f437c904672daad548fa70bc646..be59db6b0e9637bafca89a787d16cff79e36d50c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java

@@ -133,7 +133,7 @@ public class TabsTest extends ChromeTabbedActivityTestBase {

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- tab.getWebContents().evaluateJavaScript(

+ tab.getWebContents().evaluateJavaScriptForTests(

"(function() {"

+ " window.open('www.google.com');"

+ "})()",

@@ -158,7 +158,7 @@ public class TabsTest extends ChromeTabbedActivityTestBase {