android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java - Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

Issue 1258593002: Reland "Add ExecuteJavaScriptForTest and make all tests use it" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

index 10a497432a2093189b763156bfea88847b9e7767..cfc3fe82939dabc1b86d385359be1b414e943a2a 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java

@@ -70,7 +70,7 @@ public class AwJavaBridgeTest extends AwTestBase {

assertEquals("\"function\"", executeJavaScriptAndWaitForResult(

awContents, mContentsClient, "typeof test.destroy"));

int currentCallCount = client2.getOnPageFinishedHelper().getCallCount();

- awContents.evaluateJavaScript("test.destroy()", null);

+ awContents.evaluateJavaScriptForTests("test.destroy()", null);

client2.getOnPageFinishedHelper().waitForCallback(currentCallCount);

}