Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1258583002: Debugger: correctly redirect eval code. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: correctly redirect eval code. This also allows us to not always compile for debugging when debug is active. Committed: https://crrev.com/0cae607ff33725e868a217556a88ac4478774210 Cr-Commit-Position: refs/heads/master@{#29848}

Patch Set 1 #

Patch Set 2 : always include debug slots for eval #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/compiler.cc View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
please take a look.
5 years, 5 months ago (2015-07-24 10:47:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258583002/1
5 years, 5 months ago (2015-07-24 10:51:42 UTC) #4
mvstanton
lgtm
5 years, 5 months ago (2015-07-24 10:58:26 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2645) v8_mac_rel on ...
5 years, 5 months ago (2015-07-24 11:25:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258583002/20001
5 years, 5 months ago (2015-07-24 13:45:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-24 14:14:16 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0cae607ff33725e868a217556a88ac4478774210 Cr-Commit-Position: refs/heads/master@{#29848}
5 years, 5 months ago (2015-07-24 14:14:45 UTC) #12
Michael Achenbach
On 2015/07/24 14:14:45, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
5 years, 4 months ago (2015-07-27 07:59:00 UTC) #13
Yang
5 years, 4 months ago (2015-07-27 08:05:43 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1261603002/ by yangguo@chromium.org.

The reason for reverting is: Causes hang:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim....

Powered by Google App Engine
This is Rietveld 408576698