Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1258553002: X87: HydrogenCodeStubs consume stack arguments via descriptor. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: HydrogenCodeStubs consume stack arguments via descriptor. port 3334b830a512eda1f8eed678a0e6fda52b23472a (r20813). original commit message: HydrogenCodeStubs consume stack arguments via descriptor. All of this is controlled by the CallDescriptor. It's simply the case that if you specify less registers than the function arity calls for, the rest are assumed to be on the stack. Bailout handlers accept these constant stack arguments too. BUG= Committed: https://crrev.com/1359017f8089d68a000535b70f74eb926e9e20e9 Cr-Commit-Position: refs/heads/master@{#29836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +10 lines, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-24 09:27:50 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-24 09:32:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258553002/1
5 years, 5 months ago (2015-07-24 09:32:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 09:57:45 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 09:57:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1359017f8089d68a000535b70f74eb926e9e20e9
Cr-Commit-Position: refs/heads/master@{#29836}

Powered by Google App Engine
This is Rietveld 408576698