Debugger: correctly recompile toplevel eval functions for debugging.

src/debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/api.h"
 #include "src/arguments.h"
 #include "src/bootstrapper.h"
 #include "src/code-stubs.h"
@@ skipping 1439 matching lines @@
         int index =
             ComputeContinuationIndexFromPcOffset(function->code(), pc_offset);
         generator_obj->set_continuation(index);
         suspended_generators.Add(handle(generator_obj));
       }
     }
   }
 
   if (!shared->HasDebugCode()) {
     DCHECK(functions.length() > 0);
-    if (Compiler::GetDebugCode(functions.first()).is_null()) {
-      return false;
-    }
+    if (!Compiler::CompileDebugCode(functions.first())) return false;
   }
 
   for (Handle<JSFunction> const function : functions) {
     function->ReplaceCode(shared->code());
   }
 
   for (Handle<JSGeneratorObject> const generator_obj : suspended_generators) {
     int index = generator_obj->continuation();
     int pc_offset = ComputePcOffsetFromContinuationIndex(shared->code(), index);
     generator_obj->set_continuation(pc_offset);
@@ skipping 80 matching lines @@
         finder.NewCandidate(SharedFunctionInfo::cast(item));
       }
       shared = finder.Result();
       if (shared == NULL) break;
       // We found it if it's already compiled and has debug code.
       if (shared->HasDebugCode()) return handle(shared);
     }
     // If not, compile to reveal inner functions, if possible.
     if (shared->allows_lazy_compilation_without_context()) {
       HandleScope scope(isolate_);
-      if (Compiler::GetDebugCode(handle(shared)).is_null()) break;
+      if (!Compiler::CompileDebugCode(handle(shared))) break;
       continue;
     }
 
     // If not possible, comb the heap for the best suitable compile target.
     JSFunction* closure;
     {
       HeapIterator it(isolate_->heap());
       SharedFunctionInfoFinder finder(position);
       while (HeapObject* object = it.next()) {
         JSFunction* candidate_closure = NULL;
         SharedFunctionInfo* candidate = NULL;
         if (object->IsJSFunction()) {
           candidate_closure = JSFunction::cast(object);
           candidate = candidate_closure->shared();
         } else if (object->IsSharedFunctionInfo()) {
           candidate = SharedFunctionInfo::cast(object);
           if (!candidate->allows_lazy_compilation_without_context()) continue;
         } else {
           continue;
         }
         if (candidate->script() == *script) {
           finder.NewCandidate(candidate, candidate_closure);
         }
       }
       closure = finder.ResultClosure();
       shared = finder.Result();
     }
     HandleScope scope(isolate_);
     if (closure == NULL) {
-      if (Compiler::GetDebugCode(handle(shared)).is_null()) break;
+      if (!Compiler::CompileDebugCode(handle(shared))) break;
     } else {
-      if (Compiler::GetDebugCode(handle(closure)).is_null()) break;
+      if (!Compiler::CompileDebugCode(handle(closure))) break;
     }
   }
   return isolate_->factory()->undefined_value();
 }
 
 
 // Ensures the debug information is present for shared.
 bool Debug::EnsureDebugInfo(Handle<SharedFunctionInfo> shared,
                             Handle<JSFunction> function) {
   if (!shared->IsSubjectToDebugging()) return false;
@@ skipping 1170 matching lines @@
 }
 
 
 void LockingCommandMessageQueue::Clear() {
   base::LockGuard<base::Mutex> lock_guard(&mutex_);
   queue_.Clear();
 }
 
 }  // namespace internal
 }  // namespace v8