Debugger: correctly recompile toplevel eval functions for debugging.

Debugger: correctly recompile toplevel eval functions for debugging.

R=mvstanton@chromium.org

Committed: https://crrev.com/3069c43813252faedeb6cd2832f102cb83c70218
Cr-Commit-Position: refs/heads/master@{#29871}

[Yang, 2015-07-27 10:16:49]

https://codereview.chromium.org/1258503003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1258503003/diff/1/src/compiler.cc#newcode1229
src/compiler.cc:1229: isolate->debug()->OnAfterCompile(script);
Moving OnAfterCompile is necessary so that we have a function on the heap. We
can only compile eval again if we have a function, from which we can obtain the
context.

This is the scenario: we set a break point by name, but the function with that
name has not been introduced yet. So we hold onto that break point until we
compile a script that introduces the function. When we compile an eval that does
this, we call OnAfterCompile which looks through those break points. We then
realize that this eval needs to be recompiled for debug code. We comb the heap
to look for a function that can be used to compile that eval.

So we need to call OnAfterCompile after NewFunctionFromSharedFunctionInfo.

[Yang, 2015-07-27 10:16:53]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-27 10:17:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258503003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258503003/1

[commit-bot: I haz the power, 2015-07-27 10:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-27 10:43:08]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2015-07-27 12:42:56]

one nit, LGTM.

https://codereview.chromium.org/1258503003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1258503003/diff/1/src/compiler.cc#newcode1229
src/compiler.cc:1229: isolate->debug()->OnAfterCompile(script);
On 2015/07/27 10:16:49, Yang wrote:
> Moving OnAfterCompile is necessary so that we have a function on the heap. We
> can only compile eval again if we have a function, from which we can obtain
the
> context.
> 
> This is the scenario: we set a break point by name, but the function with that
> name has not been introduced yet. So we hold onto that break point until we
> compile a script that introduces the function. When we compile an eval that
does
> this, we call OnAfterCompile which looks through those break points. We then
> realize that this eval needs to be recompiled for debug code. We comb the heap
> to look for a function that can be used to compile that eval.
> 
> So we need to call OnAfterCompile after NewFunctionFromSharedFunctionInfo.

nit: this is good information, can a compressed form of it live somewhere in the
CL?

[Yang, 2015-07-27 12:50:15]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-07-27 12:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1258503003/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2015-07-27 12:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258503003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258503003/20001

[commit-bot: I haz the power, 2015-07-27 13:15:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-27 13:15:34]

Patchset 2 (id:??) landed as
https://crrev.com/3069c43813252faedeb6cd2832f102cb83c70218
Cr-Commit-Position: refs/heads/master@{#29871}

[Michael Achenbach, 2015-07-27 20:36:47]

On 2015/07/27 13:15:34, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/3069c43813252faedeb6cd2832f102cb83c70218
> Cr-Commit-Position: refs/heads/master@{#29871}

This has the same problem as the last CL:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim...

After the revert of the last CL, the bot greenified. With landing this, the test
times out again.