Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3294)

Unified Diff: chrome/browser/chromeos/drive/resource_entry_conversion.cc

Issue 12585003: drive: Add showroot=true to WAPI feed URLs and ignore "no parent" entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix browser_tests. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/resource_entry_conversion.cc
diff --git a/chrome/browser/chromeos/drive/resource_entry_conversion.cc b/chrome/browser/chromeos/drive/resource_entry_conversion.cc
index 871a2c3454864cfb5a16ffd4c8c94c7d13183614..eab965272f9aa6dd0436a72b4ea71208127641e5 100644
--- a/chrome/browser/chromeos/drive/resource_entry_conversion.cc
+++ b/chrome/browser/chromeos/drive/resource_entry_conversion.cc
@@ -39,6 +39,9 @@ DriveEntryProto ConvertResourceEntryToDriveEntryProto(
const google_apis::Link* parent_link =
entry.GetLinkByType(google_apis::Link::LINK_PARENT);
if (parent_link) {
+ // TODO(haruki): Apply mapping from an empty parent to special dummy
+ // directory. See http://crbug.com/174233. Until we implement it,
+ // ChangeListProcessor ignores such "no parent" entries.
entry_proto.set_parent_resource_id(
util::ExtractResourceIdFromUrl(parent_link->href()));
}

Powered by Google App Engine
This is Rietveld 408576698