Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: ipc/ipc_channel_nacl.h

Issue 1258323004: Reland #1: Clean up interface of attachment broker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_CHANNEL_NACL_H_ 5 #ifndef IPC_IPC_CHANNEL_NACL_H_
6 #define IPC_IPC_CHANNEL_NACL_H_ 6 #define IPC_IPC_CHANNEL_NACL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <string> 9 #include <string>
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 // ChannelReader implementation. 64 // ChannelReader implementation.
65 ReadState ReadData(char* buffer, 65 ReadState ReadData(char* buffer,
66 int buffer_len, 66 int buffer_len,
67 int* bytes_read) override; 67 int* bytes_read) override;
68 bool ShouldDispatchInputMessage(Message* msg) override; 68 bool ShouldDispatchInputMessage(Message* msg) override;
69 bool GetNonBrokeredAttachments(Message* msg) override; 69 bool GetNonBrokeredAttachments(Message* msg) override;
70 bool DidEmptyInputBuffers() override; 70 bool DidEmptyInputBuffers() override;
71 void HandleInternalMessage(const Message& msg) override; 71 void HandleInternalMessage(const Message& msg) override;
72 base::ProcessId GetSenderPID() override; 72 base::ProcessId GetSenderPID() override;
73 bool IsAttachmentBrokerEndpoint() override;
73 74
74 Mode mode_; 75 Mode mode_;
75 bool waiting_connect_; 76 bool waiting_connect_;
76 77
77 // The pipe used for communication. 78 // The pipe used for communication.
78 int pipe_; 79 int pipe_;
79 80
80 // The "name" of our pipe. On Windows this is the global identifier for 81 // The "name" of our pipe. On Windows this is the global identifier for
81 // the pipe. On POSIX it's used as a key in a local map of file descriptors. 82 // the pipe. On POSIX it's used as a key in a local map of file descriptors.
82 // For NaCl, we don't actually support looking up file descriptors by name, 83 // For NaCl, we don't actually support looking up file descriptors by name,
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 122
122 // |broker_| must outlive this instance. 123 // |broker_| must outlive this instance.
123 AttachmentBroker* broker_; 124 AttachmentBroker* broker_;
124 125
125 DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelNacl); 126 DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelNacl);
126 }; 127 };
127 128
128 } // namespace IPC 129 } // namespace IPC
129 130
130 #endif // IPC_IPC_CHANNEL_NACL_H_ 131 #endif // IPC_IPC_CHANNEL_NACL_H_
OLDNEW
« no previous file with comments | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698