Fix XmppSignalStrategy to return correct result from SendStanza().

remoting/signaling/xmpp_signal_strategy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/signaling/xmpp_signal_strategy.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 173 matching lines @@
 
 void XmppSignalStrategy::Core::Disconnect() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   if (socket_) {
     login_handler_.reset();
     stream_parser_.reset();
     writer_.reset();
     socket_.reset();
     tls_state_ = TlsState::NOT_REQUESTED;
+    read_pending_ = false;
 
     FOR_EACH_OBSERVER(Listener, listeners_,
                       OnSignalStrategyStateChange(DISCONNECTED));
   }
 }
 
 SignalStrategy::State XmppSignalStrategy::Core::GetState() const {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   if (stream_parser_) {
@@ skipping 23 matching lines @@
 
 void XmppSignalStrategy::Core::RemoveListener(Listener* listener) {
   DCHECK(thread_checker_.CalledOnValidThread());
   listeners_.RemoveObserver(listener);
 }
 
 bool XmppSignalStrategy::Core::SendStanza(scoped_ptr<buzz::XmlElement> stanza) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   if (!stream_parser_) {
-    VLOG(0) << "Dropping signalling message because XMPP "
-               "connection has been terminated.";
+    VLOG(0) << "Dropping signalling message because XMPP is not connected.";
     return false;
   }
 
   SendMessage(stanza->Str());
-  return true;
+
+  // Return false if the SendMessage() call above resulted in the SignalStrategy
+  // being disconnected.
+  return stream_parser_ != nullptr;
 }
 
 void XmppSignalStrategy::Core::SetAuthInfo(const std::string& username,
                                            const std::string& auth_token) {
   DCHECK(thread_checker_.CalledOnValidThread());
   xmpp_server_config_.username = username;
   xmpp_server_config_.auth_token = auth_token;
 }
 
 void XmppSignalStrategy::Core::SendMessage(const std::string& message) {
@@ skipping 271 matching lines @@
 std::string XmppSignalStrategy::GetNextId() {
   return base::Uint64ToString(base::RandUint64());
 }
 
 void XmppSignalStrategy::SetAuthInfo(const std::string& username,
                                      const std::string& auth_token) {
   core_->SetAuthInfo(username, auth_token);
 }
 
 }  // namespace remoting