build/java_apk.gypi - Issue 1258303003: [Android] Suppress findbugs stderr output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/java_apk.gypi

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + reenable findbugs_verbose on GN Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/java_apk.gypi

diff --git a/build/java_apk.gypi b/build/java_apk.gypi

index a1fc8574db67ca4e21145a2d2205ae5c263f8ba4..6dbb85876aae863af245d77d46bae8a3f9e1ab50 100644

--- a/build/java_apk.gypi

+++ b/build/java_apk.gypi

@@ -721,6 +721,17 @@

{

'action_name': 'findbugs_<(_target_name)',

'message': 'Running findbugs on <(_target_name)',

+ 'variables': {

+ 'additional_findbugs_args': [],

+ 'findbugs_verbose%': 0,

+ },

+ 'conditions': [

+ ['findbugs_verbose == 1', {

+ 'variables': {

+ 'additional_findbugs_args+': ['-vv'],

+ },

+ }],

+ ],

'inputs': [

'<(DEPTH)/build/android/findbugs_diff.py',

'<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',

@@ -736,6 +747,7 @@

'python', '<(DEPTH)/build/android/findbugs_diff.py',

'--auxclasspath-gyp', '>(input_jars_paths)',

'--stamp', '<(findbugs_stamp)',

+ '<@(additional_findbugs_args)',

'<(jar_path)',

« build/config/android/rules.gni ('K') | « build/java.gypi ('k') | no next file » | no next file with comments »