Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/java.gypi

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + reenable findbugs_verbose on GN Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/android/rules.gni ('K') | « build/config/android/rules.gni ('k') | build/java_apk.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index 73c550de071e310fadb3a04d871497b1d01e6269..614d50a101d492f6ce77718a08f22675a6458dac 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -227,6 +227,17 @@
{
'action_name': 'findbugs_<(_target_name)',
'message': 'Running findbugs on <(_target_name)',
+ 'variables': {
+ 'additional_findbugs_args': [],
+ 'findbugs_verbose%': 0,
+ },
+ 'conditions': [
+ ['findbugs_verbose == 1', {
+ 'variables': {
+ 'additional_findbugs_args+': ['-vv'],
+ },
+ }],
+ ],
'inputs': [
'<(DEPTH)/build/android/findbugs_diff.py',
'<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',
@@ -242,6 +253,7 @@
'python', '<(DEPTH)/build/android/findbugs_diff.py',
'--auxclasspath-gyp', '>(input_jars_paths)',
'--stamp', '<(findbugs_stamp)',
+ '<@(additional_findbugs_args)',
'<(jar_final_path)',
],
},
« build/config/android/rules.gni ('K') | « build/config/android/rules.gni ('k') | build/java_apk.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698