build/android/pylib/utils/findbugs.py - Issue 1258303003: [Android] Suppress findbugs stderr output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/findbugs.py

Issue 1258303003: [Android] Suppress findbugs stderr output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + reenable findbugs_verbose on GN Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/utils/findbugs.py

diff --git a/build/android/pylib/utils/findbugs.py b/build/android/pylib/utils/findbugs.py

index 8deb0fe274de99773ccb53be24e720fb2ba9251c..6ad856f5306aea71a08dd20a28d600b9a51573e1 100644

--- a/build/android/pylib/utils/findbugs.py

+++ b/build/android/pylib/utils/findbugs.py

@@ -142,12 +142,16 @@ def Run(exclude, classes_to_analyze, auxiliary_classes, output_file,

cmd.extend(os.path.abspath(j) for j in jars or [])

if output_file:

- cmd_helper.RunCmd(cmd)

+ _, _, stderr = cmd_helper.GetCmdStatusOutputAndError(cmd)

results_doc = xml.dom.minidom.parse(output_file)

else:

- raw_out = cmd_helper.GetCmdOutput(cmd)

+ _, raw_out, stderr = cmd_helper.GetCmdStatusOutputAndError(cmd)

results_doc = xml.dom.minidom.parseString(raw_out)

+ for line in stderr.splitlines():

+ logging.debug(' %s', line)

current_warnings_set = _ParseXmlResults(results_doc)

return (' '.join(cmd), current_warnings_set)