Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1258273006: Remove page id from title and state updating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch
Patch Set: comment nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index b1373bdb59b6e1c9ebfb7f68932bd4f244449b23..9d43c05b1139dcdc8a93e5473ea7cee7459bfabb 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -367,7 +367,7 @@ TEST_F(WebContentsImplTest, UpdateTitle) {
main_test_rfh()->SendNavigateWithParams(&params);
- contents()->UpdateTitle(main_test_rfh(), 0,
+ contents()->UpdateTitle(main_test_rfh(),
base::ASCIIToUTF16(" Lots O' Whitespace\n"),
base::i18n::LEFT_TO_RIGHT);
EXPECT_EQ(base::ASCIIToUTF16("Lots O' Whitespace"), contents()->GetTitle());
@@ -376,8 +376,7 @@ TEST_F(WebContentsImplTest, UpdateTitle) {
TEST_F(WebContentsImplTest, UpdateTitleBeforeFirstNavigation) {
ASSERT_TRUE(controller().IsInitialNavigation());
const base::string16 title = base::ASCIIToUTF16("Initial Entry Title");
- contents()->UpdateTitle(main_test_rfh(), -1, title,
- base::i18n::LEFT_TO_RIGHT);
+ contents()->UpdateTitle(main_test_rfh(), title, base::i18n::LEFT_TO_RIGHT);
EXPECT_EQ(title, contents()->GetTitle());
}
@@ -389,8 +388,7 @@ TEST_F(WebContentsImplTest, DontUseTitleFromPendingEntry) {
// Also test setting title while the first navigation is still pending.
const base::string16 title = base::ASCIIToUTF16("Initial Entry Title");
- contents()->UpdateTitle(main_test_rfh(), -1, title,
- base::i18n::LEFT_TO_RIGHT);
+ contents()->UpdateTitle(main_test_rfh(), title, base::i18n::LEFT_TO_RIGHT);
EXPECT_EQ(title, contents()->GetTitle());
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698