content/browser/renderer_host/render_view_host_unittest.cc - Issue 1258273006: Remove page id from title and state updating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 1258273006: Remove page id from title and state updating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch

Patch Set: comment nit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_unittest.cc

diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc

index 6e579595effaf5a5236b67dab11b7b3da2e01907..2a8eeb9f95cf5b56ed0b810fa115ce30a5b25373 100644

--- a/content/browser/renderer_host/render_view_host_unittest.cc

+++ b/content/browser/renderer_host/render_view_host_unittest.cc

@@ -195,12 +195,12 @@ TEST_F(RenderViewHostTest, MessageWithBadHistoryItemFiles) {

EXPECT_TRUE(PathService::Get(base::DIR_TEMP, &file_path));

file_path = file_path.AppendASCII("foo");

EXPECT_EQ(0, process()->bad_msg_count());

- test_rvh()->TestOnUpdateStateWithFile(-1, file_path);

+ test_rvh()->TestOnUpdateStateWithFile(file_path);

EXPECT_EQ(1, process()->bad_msg_count());

ChildProcessSecurityPolicyImpl::GetInstance()->GrantReadFile(

process()->GetID(), file_path);

- test_rvh()->TestOnUpdateStateWithFile(-1, file_path);

+ test_rvh()->TestOnUpdateStateWithFile(file_path);

EXPECT_EQ(1, process()->bad_msg_count());

}