Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1258273005: Revert of cc: Consider Surface active if frame received recently (Closed)

Created:
5 years, 4 months ago by brianderson
Modified:
5 years, 4 months ago
Reviewers:
sunnyps, mithro-old
CC:
chromium-reviews, cc-bugs_chromium.org, jbauman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Consider Surface active if frame received recently (patchset #7 id:120001 of https://codereview.chromium.org/1251693002/) Reason for revert: This caused regressions in 24/30fps cast tests in stead of improving them. See crbug.com/514075 for details. Original issue's description: > cc: Consider Surface active if frame received recently > > Current logic considers a child surface active if > it has submitted two frames in the last two vsyncs. > This hurts 30fps or 24fps video use cases, so change > the heuristic to consider a child surface active if it > has submitted a frame anytime within the last 3 vsyncs. > > BUG=493751 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/b189b0f12544df1f65bd5a189b005e86908b1495 > Cr-Commit-Position: refs/heads/master@{#340299} TBR=mithro@mithis.com,sunnyps@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493751 Committed: https://crrev.com/a3f4eafcd0474e5ece4fd8fc2a99cce163c17652 Cr-Commit-Position: refs/heads/master@{#340725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -221 lines) Patch
M cc/surfaces/display_scheduler.h View 2 chunks +5 lines, -10 lines 0 comments Download
M cc/surfaces/display_scheduler.cc View 8 chunks +34 lines, -58 lines 0 comments Download
M cc/surfaces/display_scheduler_unittest.cc View 1 chunk +0 lines, -153 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brianderson
Created Revert of cc: Consider Surface active if frame received recently
5 years, 4 months ago (2015-07-28 18:06:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258273005/1
5 years, 4 months ago (2015-07-28 18:07:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 18:08:30 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 18:09:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3f4eafcd0474e5ece4fd8fc2a99cce163c17652
Cr-Commit-Position: refs/heads/master@{#340725}

Powered by Google App Engine
This is Rietveld 408576698