Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 1258273002: PPC: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. Port 5dff4bdff06c0463db1e876af7541af2b715392c Original commit message: No need to pass the name explicitly to the stubs; the runtime can extract the name from the ScopeInfo (the extension of the ScriptContext) on-demand easily without any performance impact. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= NOTREECHECKS=true Committed: https://crrev.com/d8b31d881fe5bd118d748e962de1925b78d89563 Cr-Commit-Position: refs/heads/master@{#29906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -40 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/ppc/lithium-ppc.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
MTBrandyberry
5 years, 4 months ago (2015-07-28 16:19:15 UTC) #1
dstence
lgtm
5 years, 4 months ago (2015-07-28 16:23:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258273002/1
5 years, 4 months ago (2015-07-28 16:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258273002/1
5 years, 4 months ago (2015-07-30 07:27:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 07:28:45 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 07:29:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8b31d881fe5bd118d748e962de1925b78d89563
Cr-Commit-Position: refs/heads/master@{#29906}

Powered by Google App Engine
This is Rietveld 408576698