Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1258213002: [stubs] Use a single slot for context globals. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Use a single slot for context globals. Don't use different read/write slots for context globals, but let them share the same slot, which reduces the number of initial misses, and also saves some memory for large scripts. R=yangguo@chromium.org Committed: https://crrev.com/4eeafb8802aaf32dac03b91ec61e166f45b76f81 Cr-Commit-Position: refs/heads/master@{#29889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -46 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/contexts.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/scopeinfo.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M src/scopes.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-07-28 07:30:02 UTC) #1
Benedikt Meurer
Hey Yang, This is a followup optimization for context globals, which is now possible since ...
5 years, 4 months ago (2015-07-28 07:31:16 UTC) #2
Yang
On 2015/07/28 07:31:16, Benedikt Meurer wrote: > Hey Yang, > > This is a followup ...
5 years, 4 months ago (2015-07-28 08:11:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258213002/1
5 years, 4 months ago (2015-07-28 08:12:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 08:18:23 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 08:18:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eeafb8802aaf32dac03b91ec61e166f45b76f81
Cr-Commit-Position: refs/heads/master@{#29889}

Powered by Google App Engine
This is Rietveld 408576698