net/http/http_auth_cache.cc - Issue 12582012: Implement FTP auth through proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_cache.cc

Issue 12582012: Implement FTP auth through proxy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_cache.cc

diff --git a/net/http/http_auth_cache.cc b/net/http/http_auth_cache.cc

index 2cc2c0ce556249576f52b298efe7536753b1bca1..fdd106a33e6673c91d7b5bb376c35e3e9fd07a35 100644

--- a/net/http/http_auth_cache.cc

+++ b/net/http/http_auth_cache.cc

@@ -42,7 +42,9 @@ bool IsEnclosingPath(const std::string& container, const std::string& path) {

// Debug helper to check that |origin| arguments are properly formed.

void CheckOriginIsValid(const GURL& origin) {

DCHECK(origin.is_valid());

- DCHECK(origin.SchemeIs("http") || origin.SchemeIs("https"));

+ // Note that the scheme may be FTP when we're using a HTTP proxy.

+ DCHECK(origin.SchemeIs("http") || origin.SchemeIs("https") ||

+ origin.SchemeIs("ftp"));

DCHECK(origin.GetOrigin() == origin);

}