Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1258193002: User MessageLoopForIO::WatchFileDescriptor in proces_output_watcher (Closed)

Created:
5 years, 4 months ago by tbarzic
Modified:
5 years, 4 months ago
Reviewers:
rkc
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

User MessageLoopForIO::WatchFileDescriptor in proces_output_watcher The main point is to avoid usage of select for observing process' pseudo-terminal fd. Main problems with select is that it doesn't work for fd > 1024, which started to be passed to ProcessOutputWatcher. Added benefit of MessageLoopForIO::WatchFileDescriptor is that it's async, so it enables us to do some clean up for process proxy thread management. BUG=495165 TEST=Open a lot of crosh tabs (e.g. ~30). Crosh is started in all of them. Committed: https://crrev.com/6ca50550a8136fdde5fe87d9fe483826f2f0c74e Cr-Commit-Position: refs/heads/master@{#342716}

Patch Set 1 #

Patch Set 2 : fix test flakiness #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -209 lines) Patch
M chromeos/process_proxy/process_output_watcher.h View 1 2 3 3 chunks +18 lines, -24 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher.cc View 1 2 3 4 3 chunks +46 lines, -75 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher_unittest.cc View 1 2 5 chunks +20 lines, -16 lines 0 comments Download
M chromeos/process_proxy/process_proxy.h View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 1 2 8 chunks +29 lines, -64 lines 0 comments Download
M chromeos/process_proxy/process_proxy_registry.h View 4 chunks +8 lines, -1 line 0 comments Download
M chromeos/process_proxy/process_proxy_registry.cc View 1 2 4 8 chunks +28 lines, -17 lines 0 comments Download
M chromeos/process_proxy/process_proxy_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tbarzic
I think you're the only person that recently looked at this code at all :) ...
5 years, 4 months ago (2015-08-04 00:54:29 UTC) #2
tbarzic
On 2015/08/04 00:54:29, tbarzic wrote: > I think you're the only person that recently looked ...
5 years, 4 months ago (2015-08-10 17:23:33 UTC) #3
rkc
lgtm
5 years, 4 months ago (2015-08-10 18:11:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258193002/80001
5 years, 4 months ago (2015-08-10 22:03:00 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-10 22:32:53 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 22:33:41 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6ca50550a8136fdde5fe87d9fe483826f2f0c74e
Cr-Commit-Position: refs/heads/master@{#342716}

Powered by Google App Engine
This is Rietveld 408576698