DescriptionUser MessageLoopForIO::WatchFileDescriptor in proces_output_watcher
The main point is to avoid usage of select for observing process'
pseudo-terminal fd. Main problems with select is that it doesn't work
for fd > 1024, which started to be passed to ProcessOutputWatcher.
Added benefit of MessageLoopForIO::WatchFileDescriptor is that it's async,
so it enables us to do some clean up for process proxy thread management.
BUG=495165
TEST=Open a lot of crosh tabs (e.g. ~30). Crosh is started in all of them.
Committed: https://crrev.com/6ca50550a8136fdde5fe87d9fe483826f2f0c74e
Cr-Commit-Position: refs/heads/master@{#342716}
Patch Set 1 #Patch Set 2 : fix test flakiness #Patch Set 3 : . #Patch Set 4 : . #Patch Set 5 : . #
Messages
Total messages: 8 (2 generated)
|