Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: lib/src/runner/browser/browser_manager.dart

Issue 1258163002: Split out a RunnerSuite class. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner.dart ('k') | lib/src/runner/browser/iframe_listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/browser_manager.dart
diff --git a/lib/src/runner/browser/browser_manager.dart b/lib/src/runner/browser/browser_manager.dart
index 33ad2b3a0751c9223b765f8be4e9348a7d4e1dec..bbba2148b7eabded8a5debc74e1f918bc8c3fc85 100644
--- a/lib/src/runner/browser/browser_manager.dart
+++ b/lib/src/runner/browser/browser_manager.dart
@@ -11,13 +11,13 @@ import 'package:http_parser/http_parser.dart';
import 'package:pool/pool.dart';
import '../../backend/metadata.dart';
-import '../../backend/suite.dart';
import '../../backend/test_platform.dart';
import '../../util/multi_channel.dart';
import '../../util/remote_exception.dart';
import '../../util/stack_trace_mapper.dart';
import '../../utils.dart';
import '../load_exception.dart';
+import '../runner_suite.dart';
import 'iframe_test.dart';
/// A class that manages the connection to a single running browser.
@@ -68,7 +68,7 @@ class BrowserManager {
///
/// If [mapper] is passed, it's used to map stack traces for errors coming
/// from this test suite.
- Future<Suite> loadSuite(String path, Uri url, Metadata metadata,
+ Future<RunnerSuite> loadSuite(String path, Uri url, Metadata metadata,
{StackTraceMapper mapper}) async {
url = url.replace(fragment: Uri.encodeFull(JSON.encode({
"metadata": metadata.serialize(),
@@ -140,7 +140,7 @@ class BrowserManager {
asyncError.stackTrace);
}
- return new Suite(response["tests"].map((test) {
+ return new RunnerSuite(response["tests"].map((test) {
var testMetadata = new Metadata.deserialize(test['metadata']);
var testChannel = suiteChannel.virtualChannel(test['channel']);
return new IframeTest(test['name'], testMetadata, testChannel,
« no previous file with comments | « lib/src/runner.dart ('k') | lib/src/runner/browser/iframe_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698