Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1258103005: Reland of Call EnsureWebKitInitialized() before registering extensions (Closed)

Created:
5 years, 4 months ago by bashi
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Call EnsureWebKitInitialized() before registering extensions (patchset #1 id:1 of https://codereview.chromium.org/1244243003/) Reason for revert: It turns out this CL isn't the culprit of crashes. Let's reland. Original issue's description: > Revert of Call EnsureWebKitInitialized() before registering extensions (patchset #3 id:40001 of https://codereview.chromium.org/1182083006/) > > Reason for revert: > This seems the cause of many crashes > > Original issue's description: > > Call EnsureWebKitInitialized() before registering extensions > > > > Blink needs to be initialized before registering an extension because: > > - WebScriptController::registerExtension() allocates an WTF::Vector on the first > > call. > > - WTF::Vector uses PartitionAlloc. > > - PartitionAlloc's partitions needs to be initialized before allocating memory. > > Blink initialization does the job. > > > > Before this CL, partitions are initialized lazily but lazy initialization > > doesn't provide proper histogram function, which might be the cause of missing > > report for PartitionAlloc.CommittedSize UMA. > > > > BUG=501171 > > > > Committed: https://crrev.com/0d244fa5e106b3d146655a2c623539a3e1900831 > > Cr-Commit-Position: refs/heads/master@{#339200} > > TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=501171 > > Committed: https://crrev.com/2b94b05fc252c9a006ae924d0fe75ed3abecbeb2 > Cr-Commit-Position: refs/heads/master@{#339777} TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501171 Committed: https://crrev.com/0444616094fcba557a06eb292ebd568281f82c84 Cr-Commit-Position: refs/heads/master@{#340793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
bashi
Created Reland of Call EnsureWebKitInitialized() before registering extensions
5 years, 4 months ago (2015-07-28 00:42:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258103005/1
5 years, 4 months ago (2015-07-28 00:43:06 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 00:43:40 UTC) #5
bashi
jochen@, kalman@ Could you review this again? No change made.
5 years, 4 months ago (2015-07-28 00:45:40 UTC) #6
haraken
LGTM
5 years, 4 months ago (2015-07-28 05:05:32 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2015-07-28 10:55:49 UTC) #8
not at google - send to devlin
lgtm
5 years, 4 months ago (2015-07-28 16:47:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258103005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258103005/1
5 years, 4 months ago (2015-07-28 22:56:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 22:58:02 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 22:58:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0444616094fcba557a06eb292ebd568281f82c84
Cr-Commit-Position: refs/heads/master@{#340793}

Powered by Google App Engine
This is Rietveld 408576698