DescriptionReland of Call EnsureWebKitInitialized() before registering extensions (patchset #1 id:1 of https://codereview.chromium.org/1244243003/)
Reason for revert:
It turns out this CL isn't the culprit of crashes. Let's reland.
Original issue's description:
> Revert of Call EnsureWebKitInitialized() before registering extensions (patchset #3 id:40001 of https://codereview.chromium.org/1182083006/)
>
> Reason for revert:
> This seems the cause of many crashes
>
> Original issue's description:
> > Call EnsureWebKitInitialized() before registering extensions
> >
> > Blink needs to be initialized before registering an extension because:
> > - WebScriptController::registerExtension() allocates an WTF::Vector on the first
> > call.
> > - WTF::Vector uses PartitionAlloc.
> > - PartitionAlloc's partitions needs to be initialized before allocating memory.
> > Blink initialization does the job.
> >
> > Before this CL, partitions are initialized lazily but lazy initialization
> > doesn't provide proper histogram function, which might be the cause of missing
> > report for PartitionAlloc.CommittedSize UMA.
> >
> > BUG=501171
> >
> > Committed: https://crrev.com/0d244fa5e106b3d146655a2c623539a3e1900831
> > Cr-Commit-Position: refs/heads/master@{#339200}
>
> TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=501171
>
> Committed: https://crrev.com/2b94b05fc252c9a006ae924d0fe75ed3abecbeb2
> Cr-Commit-Position: refs/heads/master@{#339777}
TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501171
Committed: https://crrev.com/0444616094fcba557a06eb292ebd568281f82c84
Cr-Commit-Position: refs/heads/master@{#340793}
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 13 (3 generated)
|