Split 'CookieOptions' out into a .h/.cc file.

Split 'CookieOptions' out into a .h/.cc file.

I need to add a member to CookieOptions in order to support First-Party
Only cookies, but doing so makes CookieOptions' constructor "complex".
Splitting that work out into a separate patch for clarity.

BUG=459154
Committed: https://crrev.com/765edf7c2d4f183663d6eb54964fc41f261be2df
Cr-Commit-Position: refs/heads/master@{#340657}

[vabr (Chromium), 2015-07-27 11:35:44]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-07-27 11:35:44]

https://codereview.chromium.org/1258023002/diff/1/net/cookies/cookie_options.h
File net/cookies/cookie_options.h (right):

https://codereview.chromium.org/1258023002/diff/1/net/cookies/cookie_options....
net/cookies/cookie_options.h:15: class CookieOptions {
The only target in net_common.gypi is of type "component". Looking at
cookie_monster.*, you probably need to use NET_EXPORT here to make component
linking work. Bots which do not do component linking should work fine, maybe
that explains how some of them pass.

[Mike West, 2015-07-27 12:03:59]

mkwst@chromium.org changed reviewers:
+ eroman@chromium.org

[Mike West, 2015-07-27 12:04:00]

Ha! Thanks, Vaclav! I think that did it.

eroman@, mind taking a look at this tiny change?

[Mike West, 2015-07-27 14:25:23]

On 2015/07/27 at 12:04:00, Mike West wrote:
> Ha! Thanks, Vaclav! I think that did it.
> 
> eroman@, mind taking a look at this tiny change?

https://codereview.chromium.org/1253353004 is the WIP patch that will require
this change.

[eroman, 2015-07-27 18:02:03]

lgtm

https://codereview.chromium.org/1258023002/diff/20001/net/cookies/cookie_opti...
File net/cookies/cookie_options.cc (right):

https://codereview.chromium.org/1258023002/diff/20001/net/cookies/cookie_opti...
net/cookies/cookie_options.cc:5: // Brought to you by number 42.
nit: While I appreciate the humor, not sure this is necessary :)

[Mike West, 2015-07-27 18:09:58]

On 2015/07/27 at 18:02:03, eroman wrote:
> lgtm
> 
>
https://codereview.chromium.org/1258023002/diff/20001/net/cookies/cookie_opti...
> File net/cookies/cookie_options.cc (right):
> 
>
https://codereview.chromium.org/1258023002/diff/20001/net/cookies/cookie_opti...
> net/cookies/cookie_options.cc:5: // Brought to you by number 42.
> nit: While I appreciate the humor, not sure this is necessary :)

It's copy/pasted from the .h file. :)

But, you know, happy to drop it. *shrug*

[eroman, 2015-07-27 18:29:12]

On Mon, Jul 27, 2015 at 11:09 AM, <mkwst@chromium.org> wrote:

> On 2015/07/27 at 18:02:03, eroman wrote:
>
>> lgtm
>>
>
>
>
>
https://codereview.chromium.org/1258023002/diff/20001/net/cookies/cookie_opti...
>
>> File net/cookies/cookie_options.cc (right):
>>
>
>
>
>
https://codereview.chromium.org/1258023002/diff/20001/net/cookies/cookie_opti...
>
>> net/cookies/cookie_options.cc:5: // Brought to you by number 42.
>> nit: While I appreciate the humor, not sure this is necessary :)
>>
>
> It's copy/pasted from the .h file. :)
>
> But, you know, happy to drop it. *shrug*
>

Ah indeed it is!

Whether you decide to keep it or not, LGTM.


>
> https://codereview.chromium.org/1258023002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mike West, 2015-07-28 09:19:38]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-07-28 09:20:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1258023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1258023002/20001

[commit-bot: I haz the power, 2015-07-28 09:24:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-28 09:25:47]

Patchset 2 (id:??) landed as
https://crrev.com/765edf7c2d4f183663d6eb54964fc41f261be2df
Cr-Commit-Position: refs/heads/master@{#340657}