Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1258013002: Implement ATK Action & Document interface for WebContent Accessibility. (Closed)

Created:
5 years, 5 months ago by shreeramk
Modified:
5 years, 4 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement ATK Action & Document interface for WebContent Accessibility. BUG=463671 Committed: https://crrev.com/b3708c52ff39de83e27e2f55051d9b081ed4ba65 Cr-Commit-Position: refs/heads/master@{#340640}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixing nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_auralinux.cc View 1 4 chunks +177 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
shreeramk
PTAL. Thanks :)
5 years, 4 months ago (2015-07-27 18:03:22 UTC) #2
dmazzoni
lgtm https://codereview.chromium.org/1258013002/diff/1/content/browser/accessibility/browser_accessibility_auralinux.cc File content/browser/accessibility/browser_accessibility_auralinux.cc (right): https://codereview.chromium.org/1258013002/diff/1/content/browser/accessibility/browser_accessibility_auralinux.cc#newcode61 content/browser/accessibility/browser_accessibility_auralinux.cc:61: static const gchar* browser_accessibility_get_description(AtkAction* atk_action, This function is ...
5 years, 4 months ago (2015-07-27 18:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1258013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1258013002/20001
5 years, 4 months ago (2015-07-28 04:33:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-28 04:37:41 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 04:38:20 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b3708c52ff39de83e27e2f55051d9b081ed4ba65
Cr-Commit-Position: refs/heads/master@{#340640}

Powered by Google App Engine
This is Rietveld 408576698