Issue 1257963003: Fix chromium style checker error on windows sandbox code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257963003: Fix chromium style checker error on windows sandbox code. (Closed)

Created:
5 years, 4 months ago by Nico

Modified:
5 years, 4 months ago

Reviewers:
wfh, Yoshisato Yanagisawa, Will Harris

CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix chromium style checker error on windows sandbox code. This change fixes "Complex constructor has an inline body." error generated by Windows clang. Original patch from yyanisawa@chromium.org, reviewed at https://codereview.chromium.org/1252913006/ BUG=82385 TBR=wfh Committed: https://chromium.googlesource.com/chromium/src/+/d6c3a2783d37f45787cd9a62a36b360ab829eb34

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -3 lines)			Patch
M	sandbox/win/src/Wow64.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sandbox/win/src/Wow64.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sandbox/win/src/Wow64_64.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sandbox/win/src/job.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sandbox/win/src/job.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257963003/1

5 years, 4 months ago (2015-07-28 15:25:14 UTC) #3

Nico

Committed patchset #1 (id:1) manually as d6c3a2783d37f45787cd9a62a36b360ab829eb34 (presubmit successful).

5 years, 4 months ago (2015-07-28 16:00:14 UTC) #5

Message was sent while issue was closed.

lgtm thanks.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages