Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1257953003: Do not report Resource Timing for iframe navigations when restored from history (Closed)

Created:
5 years, 5 months ago by Kunihiko Sakamoto
Modified:
5 years, 3 months ago
Reviewers:
Nate Chapin, Mike West
CC:
gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not report Resource Timing for iframe navigations when restored from history In a back/forward navigation, iframe navigates to its final URL directly. Iframes should not report Resource Timing except for the initial navigation requested by the parent document. BUG=511616 TEST=http/tests/misc/resource-timing-iframe-restored-from-history.html Committed: https://crrev.com/acf50d484e3b9fdc676a75d266303c7163b2f59f git-svn-id: svn://svn.chromium.org/blink/trunk@199553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test verifies correct entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, --1 lines) Patch
A LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/misc/resources/frame-final-url.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/misc/resources/frame-initial-url.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Kunihiko Sakamoto
5 years, 5 months ago (2015-07-27 09:42:40 UTC) #2
Mike West
LGTM % test nit. https://codereview.chromium.org/1257953003/diff/1/LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html File LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html (right): https://codereview.chromium.org/1257953003/diff/1/LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html#newcode17 LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html:17: shouldBe("performance.getEntriesByName('http://127.0.0.1:8000/misc/resources/frame-final-url.html').length", '0'); Can you verify ...
5 years, 4 months ago (2015-07-27 12:38:18 UTC) #3
Kunihiko Sakamoto
https://codereview.chromium.org/1257953003/diff/1/LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html File LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html (right): https://codereview.chromium.org/1257953003/diff/1/LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html#newcode17 LayoutTests/http/tests/misc/resource-timing-iframe-restored-from-history.html:17: shouldBe("performance.getEntriesByName('http://127.0.0.1:8000/misc/resources/frame-final-url.html').length", '0'); On 2015/07/27 12:38:17, Mike West wrote: > ...
5 years, 4 months ago (2015-07-28 03:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257953003/20001
5 years, 4 months ago (2015-07-28 03:17:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199553
5 years, 4 months ago (2015-07-28 03:19:41 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:49:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acf50d484e3b9fdc676a75d266303c7163b2f59f

Powered by Google App Engine
This is Rietveld 408576698