Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1257923002: content: Remove unused speex related code. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
philipj_slow, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Remove unused speex related code. With the discussion of third_party/speex/OWNERS in chromium-dev mailing list we ended up turning out that this code was actually not used. https://groups.google.com/a/chromium.org/d/topic/chromium-dev/tBiPPpqfku4/discussion BUG=513929 TEST=content_unittests R=philip@opera.com,brettw@chromium.org Committed: https://crrev.com/152a9729a7d1adb8582b4bec8ccf8f797c6f6987 Cr-Commit-Position: refs/heads/master@{#340637}

Patch Set 1 #

Patch Set 2 : rip out speex code #

Patch Set 3 : gn format #

Patch Set 4 : rm more references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -148 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M build/gn_migration.gypi View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D build/linux/unbundle/speex.gyp View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/audio_encoder.h View 1 chunk +2 lines, -10 lines 0 comments Download
M content/browser/speech/audio_encoder.cc View 1 2 chunks +2 lines, -75 lines 0 comments Download
M content/browser/speech/google_one_shot_remote_engine.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/speech/google_streaming_remote_engine.cc View 3 chunks +1 line, -4 lines 0 comments Download
M content/content_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
tfarina
5 years, 4 months ago (2015-07-27 12:02:31 UTC) #2
philipj_slow
lgtm I also see some matches for "speex" in build/gn_migration.gypi and build/linux/unbundle/, can those also ...
5 years, 4 months ago (2015-07-27 12:19:37 UTC) #3
tfarina
+Brett for review!
5 years, 4 months ago (2015-07-27 18:32:23 UTC) #5
brettw
lgtm
5 years, 4 months ago (2015-07-27 19:17:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257923002/60001
5 years, 4 months ago (2015-07-28 03:03:22 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-28 04:04:00 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 04:05:06 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/152a9729a7d1adb8582b4bec8ccf8f797c6f6987
Cr-Commit-Position: refs/heads/master@{#340637}

Powered by Google App Engine
This is Rietveld 408576698