Issue 1257863004: Just remove --css-mixins: {...}; in presubmit checked contents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257863004: Just remove --css-mixins: {...}; in presubmit checked contents (Closed)

Created:
5 years, 4 months ago by Dan Beam

Modified:
5 years, 4 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Just remove --css-mixins: {...}; in presubmit checked contents They're proving mildly annoying to handle. I should just really get a better parser going with an LALR grammar or something. Maybe https://github.com/danbeam/css-py/tree/css3 ? BUG=512147 R=tbreisacher@chromium.org Committed: https://crrev.com/92c9e3f3dd647edf019d0c4b5441b20bf7ff95fa Cr-Commit-Position: refs/heads/master@{#341257}

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/web_dev_style/css_checker.py	View		3 chunks	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/web_dev_style/css_checker_test.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257863004/1

5 years, 4 months ago (2015-07-31 01:04:55 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-07-31 01:14:47 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/92c9e3f3dd647edf019d0c4b5441b20bf7ff95fa
Cr-Commit-Position: refs/heads/master@{#341257}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages