Chromium Code Reviews Chromium Code Reviews
Issue
1257823003:
Revert of Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (Closed)
DescriptionRevert of Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (patchset #11 id:250001 of https://codereview.chromium.org/1247283004/)
Reason for revert:
Causes app_banner/app-banner-event-prompt.html failure,
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=app_banner%2Fapp-banner-event-prompt.html
Original issue's description:
> Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty
>
> This stops the event holding a ScriptPromise as a member, which may
> lead to a memory leak. Instead, ScriptPromiseProperty members are held
> as members in the event. A WebCallbacks subclass is used to store a
> pointer to the necessary ScriptPromiseProperty in the associated event,
> with the interface exposed to Chromium. When a banner event is resolved,
> the WebCallbacks implementation in modules/app_banner looks up the
> ScriptPromiseProperty and resolves its promise. This also makes
> resolving the prompt promise simpler as well, as it occurs entirely in the
> event.
>
> This CL also removes the app-banner-event-prompt.html test from
> LeakExpectations, and fixes some bugs in the test relating to promise
> resolution.
>
> BUG=504675
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199472
TBR=mlamouri@chromium.org,yhirano@chromium.org,dominickn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504675
Committed: https://crrev.com/537f90db49913a16a493166aa02521cb1fe1e04a
git-svn-id: svn://svn.chromium.org/blink/trunk@199666 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
