Make the pnacl translator files in chrome depend on the pnacl_translator stamp.

Make the pnacl translator files in chrome depend on the pnacl_translator stamp.

Otherwise, the pnacl files won't get re-layed out when only
the pnacl translator files have changed.

BUG=none
TEST=
(1) ninja -C out/Release pnacl_support_extension
(2) touch the SOURCE_SHA1 file (or change TOOLS_REVISION + hashes, and run gclient runhooks)
(3) ninja again (gets re-layed out)
(4) ninja again (nothing happens)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189988

[Mark Seaborn, 2013-03-22 16:25:50]

https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untru...
File
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp
(right):

https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untru...
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp:31:
'<(DEPTH)/native_client/toolchain/.tars/naclsdk_pnacl_translator.tgz',
I don't think pnacl_component_crx_gen.py reads this .tgz file, does it?  If it
doesn't, then this doesn't seem like the right dependency to declare.

[jvoung - send to chromium..., 2013-03-22 16:28:49]

https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untru...
File
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp
(right):

https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untru...
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp:31:
'<(DEPTH)/native_client/toolchain/.tars/naclsdk_pnacl_translator.tgz',
On 2013/03/22 16:25:50, Mark Seaborn wrote:
> I don't think pnacl_component_crx_gen.py reads this .tgz file, does it?  If it
> doesn't, then this doesn't seem like the right dependency to declare.

It doesn't read the .tgz file itself, but it reads the files from various
subdirs in the native_client/toolchain/pnacl_translator directory. The content
of native_client/toolchain/pnacl_translator comes from that tarball though.

Is there a way to make a recursive wildcard dependency on the contents of
native_client/toolchain/pnacl_translator?

[Mark Seaborn, 2013-03-22 16:37:47]

On 22 March 2013 09:28, <jvoung@google.com> wrote:

>
> https://codereview.chromium.**org/12578018/diff/1/ppapi/**
> native_client/src/untrusted/**pnacl_support_extension/pnacl_**
>
support_extension.gyp<https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp>
> File
> ppapi/native_client/src/**untrusted/pnacl_support_**
> extension/pnacl_support_**extension.gyp
> (right):
>
> https://codereview.chromium.**org/12578018/diff/1/ppapi/**
> native_client/src/untrusted/**pnacl_support_extension/pnacl_**
>
support_extension.gyp#**newcode31<https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp#newcode31>
> ppapi/native_client/src/**untrusted/pnacl_support_**
> extension/pnacl_support_**extension.gyp:31:
> '<(DEPTH)/native_client/**toolchain/.tars/naclsdk_pnacl_**translator.tgz',
> On 2013/03/22 16:25:50, Mark Seaborn wrote:
>
>> I don't think pnacl_component_crx_gen.py reads this .tgz file, does it?
>>  If it
>>
> doesn't, then this doesn't seem like the right dependency to declare.
>>
>
> It doesn't read the .tgz file itself, but it reads the files from
> various subdirs in the native_client/toolchain/pnacl_**translator
> directory. The content of native_client/toolchain/pnacl_**translator comes
> from that tarball though.
>

What unpacks native_client/toolchain/pnacl_translator these days?

If it's the gclient hooks, pnacl_support_extension should declare a direct
dependency on a stamp file in native_client/toolchain/pnacl_translator.

If it's a Gyp step, pnacl_support_extension should declare a dependency on
the Gyp step.  But I don't think it is, because Gyp steps shouldn't be
writing to native_client/toolchain/pnacl_translator (since that's in the
source tree).


> Is there a way to make a recursive wildcard dependency on the contents
> of native_client/toolchain/pnacl_translator?
>

I'm pretty sure there isn't a way to do that in Gyp:  make, ninja, MSVS,
xcodebuild, etc. won't support that.  You have to use stamp files instead.

Mark

[jvoung - send to chromium..., 2013-03-22 16:44:41]

On 2013/03/22 16:37:47, Mark Seaborn wrote:
> On 22 March 2013 09:28, <mailto:jvoung@google.com> wrote:
> 
> >
> > https://codereview.chromium.**org/12578018/diff/1/ppapi/**
> > native_client/src/untrusted/**pnacl_support_extension/pnacl_**
> >
>
support_extension.gyp<https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp>
> > File
> > ppapi/native_client/src/**untrusted/pnacl_support_**
> > extension/pnacl_support_**extension.gyp
> > (right):
> >
> > https://codereview.chromium.**org/12578018/diff/1/ppapi/**
> > native_client/src/untrusted/**pnacl_support_extension/pnacl_**
> >
>
support_extension.gyp#**newcode31<https://codereview.chromium.org/12578018/diff/1/ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp#newcode31>
> > ppapi/native_client/src/**untrusted/pnacl_support_**
> > extension/pnacl_support_**extension.gyp:31:
> > '<(DEPTH)/native_client/**toolchain/.tars/naclsdk_pnacl_**translator.tgz',
> > On 2013/03/22 16:25:50, Mark Seaborn wrote:
> >
> >> I don't think pnacl_component_crx_gen.py reads this .tgz file, does it?
> >>  If it
> >>
> > doesn't, then this doesn't seem like the right dependency to declare.
> >>
> >
> > It doesn't read the .tgz file itself, but it reads the files from
> > various subdirs in the native_client/toolchain/pnacl_**translator
> > directory. The content of native_client/toolchain/pnacl_**translator comes
> > from that tarball though.
> >
> 
> What unpacks native_client/toolchain/pnacl_translator these days?
> 
> If it's the gclient hooks, pnacl_support_extension should declare a direct
> dependency on a stamp file in native_client/toolchain/pnacl_translator.

It's runhooks. I changed it to depend on the SOURCE_SHA1 stamp file that
native_client/build/download_utils.py writes into the directory.



> 
> If it's a Gyp step, pnacl_support_extension should declare a dependency on
> the Gyp step.  But I don't think it is, because Gyp steps shouldn't be
> writing to native_client/toolchain/pnacl_translator (since that's in the
> source tree).
> 
> 
> > Is there a way to make a recursive wildcard dependency on the contents
> > of native_client/toolchain/pnacl_translator?
> >
> 
> I'm pretty sure there isn't a way to do that in Gyp:  make, ninja, MSVS,
> xcodebuild, etc. won't support that.  You have to use stamp files instead.
> 
> Mark

[Mark Seaborn, 2013-03-22 16:49:47]

LGTM

[commit-bot: I haz the power, 2013-03-22 18:23:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/12578018/10001

[jvoung (off chromium), 2013-03-23 04:48:50]

Committed patchset #2 manually as r189988 (presubmit successful).